Default to encrypted IP regex handling, add explicit trusted-server plaintext override#248
Closed
Copilot wants to merge 2 commits into
Closed
Default to encrypted IP regex handling, add explicit trusted-server plaintext override#248Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Update package to enforce encryption for IP handling
Default to encrypted IP regex handling, add explicit trusted-server plaintext override
May 27, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
- Coverage 73.43% 71.42% -2.01%
==========================================
Files 41 40 -1
Lines 1547 1512 -35
==========================================
- Hits 1136 1080 -56
- Misses 411 432 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Collaborator
|
Accidentally set this one to use GPT mini lol XD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue called for package defaults that maximize security for IP-related handling, while still allowing trusted processing servers to skip encryption for performance. This change makes encrypted regex handling the default and introduces an explicit opt-out path for trusted environments.
Behavior change: secure default for IP regex loading
ExtractionHeuristicPreValidatornow resolves Drogon IP regex via a helper that:S3_LOG_EXTRACTION_ENCRYPT_IP_REGEXdefault: enabled),Trusted-server override path
S3_LOG_EXTRACTION_ENCRYPT_IP_REGEX=falseS3_LOG_EXTRACTION_DROGON_IP_REGEX=<plaintext regex>EnvironmentError.Focused coverage + docs alignment